[libcxx-commits] [PATCH] D131324: [libc++][CI] Updates and improves the Docker image.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with comment changes.



================
Comment at: libcxx/utils/ci/Dockerfile:67-68
 # Make the latest version of Clang the "default" compiler on the system
-# TODO: In the future, all jobs should be using an explicitly-versioned version of Clang instead,
-#       and we can get rid of this entirely.
-RUN ln -fs /usr/bin/clang++-$LLVM_LATEST_VERSION /usr/bin/c++ && [ -e $(readlink /usr/bin/c++) ]
-RUN ln -fs /usr/bin/clang-$LLVM_LATEST_VERSION /usr/bin/cc && [ -e $(readlink /usr/bin/cc) ]
+# TODO LLVM 16: All jobs should be using an explicitly-versioned version of Clang instead,
+#               and we can get rid of this entirely.
+RUN ln -fs /usr/bin/clang++-14 /usr/bin/c++ && [ -e $(readlink /usr/bin/c++) ]
----------------



================
Comment at: libcxx/utils/ci/Dockerfile:73
 # Install clang-format
-RUN apt-get update && apt-get install -y clang-format-$LLVM_LATEST_VERSION
-RUN ln -s /usr/bin/clang-format-$LLVM_LATEST_VERSION /usr/bin/clang-format && [ -e $(readlink /usr/bin/clang-format) ]
-RUN ln -s /usr/bin/git-clang-format-$LLVM_LATEST_VERSION /usr/bin/git-clang-format && [ -e $(readlink /usr/bin/git-clang-format) ]
+# TODO Determine whether we want to use the lastest stable clang-format release or the ToT in our ToT builds
+# TODO LLVM 16 remove hard-coded version 14 and the symlinks
----------------
IMO we should always use the latest *stable* version of clang-format available. We shouldn't build it from source, though, that's overkill.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131324/new/

https://reviews.llvm.org/D131324