[libcxx-commits] [PATCH] D131952: [libc++] Make memory_resource allocate [[nodiscard]]

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D131952#3726190 <https://reviews.llvm.org/D131952#3726190>, @J-Camilleri wrote:

> In D131952#3725591 <https://reviews.llvm.org/D131952#3725591>, @philnik wrote:
>
>> This isn't implementing P0600. P0600 is against N4700, which was the C++ working draft at some point. `experimental/memory_resource` implements LFTSv2, where `memory_resource::allocate` isn't `[[nodiscard]]`.
>
> Thanks for the quick reply and clarification. It is my first time trying to contribute here and I did not know the about the distinction.

No worries. The difference is indeed quite subtle.

> Am I correct in thinking that selecting 'Abandon Revision' as an action is enough to decline this?

Yes, that's enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131952/new/

https://reviews.llvm.org/D131952