[libcxx-commits] [PATCH] D131952: [libc++] Make memory_resource allocate [[nodiscard]]
Jonathan Camilleri via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 16 07:52:37 PDT 2022
J-Camilleri abandoned this revision.
J-Camilleri added a comment.
In D131952#3725591 <https://reviews.llvm.org/D131952#3725591>, @philnik wrote:
> This isn't implementing P0600. P0600 is against N4700, which was the C++ working draft at some point. `experimental/memory_resource` implements LFTSv2, where `memory_resource::allocate` isn't `[[nodiscard]]`.
Thanks for the quick reply and clarification. It is my first time trying to contribute here and I did not know the about the distinction.
Am I correct in thinking that selecting 'Abandon Revision' as an action is enough to decline this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131952/new/
https://reviews.llvm.org/D131952
More information about the libcxx-commits
mailing list