[libcxx-commits] [PATCH] D131483: [libcxx] [test] Make some threading tests more robust

Wed Aug 10 12:30:34 PDT 2022

mstorsjo added a comment.

In D131483#3713843 <https://reviews.llvm.org/D131483#3713843>, @Mordante wrote:

> LGTM, with a nit. I would have preferred to do D131484 <https://reviews.llvm.org/D131484> before this one. (I don't think it's worth your time to inverse the order now.)

I'm totally ok with landing D131484 <https://reviews.llvm.org/D131484> before this one; I just sent them out in parallel for reviewing.

================
Comment at: libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp:40
+
+#if !defined(TEST_HAS_SANITIZERS)
+ms Tolerance = ms(200);
----------------
Mordante wrote:
> Can you add the comment of the other similar tests (See D131484)
Sure (although some of the existing ones also lack the comment, e.g. the third diff here on phab). Also, if landing D131484 and renaming the define to `TEST_IS_SLOW`, should the comments be reworded slightly (all of them)? Because I was hitting the tolerance when running without sanitizers too...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131483/new/

https://reviews.llvm.org/D131483