[libcxx-commits] [PATCH] D131483: [libcxx] [test] Make some threading tests more robust

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 10 12:24:33 PDT 2022


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM, with a nit. I would have preferred to do D131484 <https://reviews.llvm.org/D131484> before this one. (I don't think it's worth your time to inverse the order now.)



================
Comment at: libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_try_to_lock.pass.cpp:40
+
+#if !defined(TEST_HAS_SANITIZERS)
+ms Tolerance = ms(200);
----------------
Can you add the comment of the other similar tests (See D131484)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131483/new/

https://reviews.llvm.org/D131483



More information about the libcxx-commits mailing list