[libcxx-commits] [PATCH] D130968: [libc++][ranges] Fix the return value of `{copy, move}_backward`.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 2 15:30:27 PDT 2022
ldionne accepted this revision.
ldionne added inline comments.
================
Comment at: libcxx/include/__algorithm/ranges_move_backward.h:44-45
+ auto __last_iter = ranges::next(__first, std::move(__last));
+ auto __ret = ranges::move(std::make_reverse_iterator(__last_iter),
std::make_reverse_iterator(__first),
std::make_reverse_iterator(__result));
----------------
philnik wrote:
> Pre-existing: Could you make `copy` and `move` consistent w.r.t. using `__reverse_range`?
I'm neutral on this given that we're about to refactor these algorithms significantly to remove their dependency on `reverse_iterator` altogether.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130968/new/
https://reviews.llvm.org/D130968
More information about the libcxx-commits
mailing list