[libcxx-commits] [PATCH] D130968: [libc++][ranges] Fix the return value of `{copy, move}_backward`.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 2 02:54:09 PDT 2022


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nit.



================
Comment at: libcxx/include/__algorithm/ranges_move_backward.h:44-45
+    auto __last_iter = ranges::next(__first, std::move(__last));
+    auto __ret = ranges::move(std::make_reverse_iterator(__last_iter),
                               std::make_reverse_iterator(__first),
                               std::make_reverse_iterator(__result));
----------------
Pre-existing: Could you make `copy` and `move` consistent w.r.t. using `__reverse_range`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130968/new/

https://reviews.llvm.org/D130968



More information about the libcxx-commits mailing list