[libcxx-commits] [PATCH] D124375: [runtimes] [cmake] Fix -Werror detection in common build configs
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 25 22:44:58 PDT 2022
mstorsjo added inline comments.
Comment at: libcxx/cmake/config-ix.cmake:15
# link with --uwnindlib=none. Check if that option works.
llvm_check_compiler_linker_flag(C "--unwindlib=none" CXX_SUPPORTS_UNWINDLIB_EQ_NONE_FLAG)
> Should we drop this check as well since this is done in `runtimes/CMakeLists.txt`?
I guess we could do that too, now that using `runtimes/` is mandatory. In one sense, it's a bit of a bigger step than before though - then libcxx would start relying on specific cmake variables being set, without the code for setting the variables residing in libcxx itself.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits