[libcxx-commits] [PATCH] D124375: [runtimes] [cmake] Fix -Werror detection in common build configs

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/cmake/config-ix.cmake:15
 # link with --uwnindlib=none. Check if that option works.
 llvm_check_compiler_linker_flag(C "--unwindlib=none" CXX_SUPPORTS_UNWINDLIB_EQ_NONE_FLAG)
 
----------------
phosek wrote:
> Should we drop this check as well since this is done in `runtimes/CMakeLists.txt`?
I guess we could do that too, now that using `runtimes/` is mandatory. In one sense, it's a bit of a bigger step than before though - then libcxx would start relying on specific cmake variables being set, without the code for setting the variables residing in libcxx itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124375/new/

https://reviews.llvm.org/D124375