[libcxx-commits] [PATCH] D124375: [runtimes] [cmake] Fix -Werror detection in common build configs

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/cmake/config-ix.cmake:15
 # link with --uwnindlib=none. Check if that option works.
 llvm_check_compiler_linker_flag(C "--unwindlib=none" CXX_SUPPORTS_UNWINDLIB_EQ_NONE_FLAG)
 
----------------
Should we drop this check as well since this is done in `runtimes/CMakeLists.txt`?


================
Comment at: libunwind/cmake/config-ix.cmake:12
 # --unwindlib=none is supported, and use that if possible.
 llvm_check_compiler_linker_flag(C "--unwindlib=none" CXX_SUPPORTS_UNWINDLIB_EQ_NONE_FLAG)
 
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124375/new/

https://reviews.llvm.org/D124375