[libcxx-commits] [PATCH] D124375: [runtimes] [cmake] Fix -Werror detection in common build configs

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 25 08:56:43 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Thanks for noticing this! I had indeed noticed some warnings when we built libc++, but didn't realize this would mess with our detection of `-Werror`'s availability.

LGTM once we've fixed the issues that prevent the CI from passing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124375/new/

https://reviews.llvm.org/D124375



More information about the libcxx-commits mailing list