[libcxx-commits] [PATCH] D124375: [runtimes] [cmake] Fix -Werror detection in common build configs

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a subscriber: daltenty.
mstorsjo added a comment.

This exposes some preexisting warnings in some build configs, that weren’t caught before as `LIBCXX_ENABLE_WERROR` didn’t end up having any effect. The arm builders warnings should be fixed by D124371 <https://reviews.llvm.org/D124371>.

The AIX 32 bit build produces these warnings:

  /scratch/powerllvm/cpap8006/llvm-project/libcxx-ci/build/aix/include/c++/v1/atomic:1005:12: error: large atomic operation may incur significant performance penalty; the access size (8 bytes) exceeds the max lock-free size (4  bytes) [-Werror,-Watomic-alignment]
      return __c11_atomic_fetch_add(&__a->__a_value, __delta, static_cast<__memory_order_underlying_t>(__order));

@daltenty - what do you want to do about it? Add `LIBCXX_ENABLE_WERROR=OFF` in the AIX build config (which also would affect the 64 bit build), do silence it differently somehow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124375/new/

https://reviews.llvm.org/D124375