[libcxx-commits] [PATCH] D122745: [NFC][libc++][test] Move time tests.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Apr 12 08:48:24 PDT 2022

Mordante added a comment.

In D122745#3442890 <https://reviews.llvm.org/D122745#3442890>, @ldionne wrote:

> In D122745#3429771 <https://reviews.llvm.org/D122745#3429771>, @Mordante wrote:
>> In D122745#3427118 <https://reviews.llvm.org/D122745#3427118>, @ldionne wrote:
>>> Before pushing this, can you please make sure no other review added something in the old directory? I don't think that's the case, but just to be sure. Thanks!
>> I only found D56692 <https://reviews.llvm.org/D56692>, but that's quite old and not in active development. It only adds new test so when it's revived it's probably easier to copy the existing changes to a main manually.
> Sorry, I guess what I meant is just "please check that there are no additional tests to move after you've rebased this onto main".
> I have no concerns with landing this, but we should do it soon to reduce the potential of conflicts.

Ah clear. I'll make sure there are no extra tests after rebasing. But I'm sure there will be none.
I'll land it now.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list