[libcxx-commits] [PATCH] D122745: [NFC][libc++][test] Move time tests.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 11 08:20:36 PDT 2022


ldionne added a comment.

In D122745#3429771 <https://reviews.llvm.org/D122745#3429771>, @Mordante wrote:

> In D122745#3427118 <https://reviews.llvm.org/D122745#3427118>, @ldionne wrote:
>
>> Before pushing this, can you please make sure no other review added something in the old directory? I don't think that's the case, but just to be sure. Thanks!
>
> I only found D56692 <https://reviews.llvm.org/D56692>, but that's quite old and not in active development. It only adds new test so when it's revived it's probably easier to copy the existing changes to a main manually.

Sorry, I guess what I meant is just "please check that there are no additional tests to move after you've rebased this onto main".

I have no concerns with landing this, but we should do it soon to reduce the potential of conflicts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122745/new/

https://reviews.llvm.org/D122745



More information about the libcxx-commits mailing list