[libcxx-commits] [PATCH] D122738: [libc++][test] Use the Japanese locale.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Apr 8 10:58:27 PDT 2022
Mordante added a comment.
In D122738#3439685 <https://reviews.llvm.org/D122738#3439685>, @ldionne wrote:
> LGTM, but have you verified that we were running that test in the CI? Since it `REQUIRES: locale.ja_JP.UTF-8`, we would simply skip it if the CI node didn't support that locale. Please make sure that's not what's happening, as we would simply lose coverage of that test.
Thanks for the review!
I indeed have verified that, per https://reviews.llvm.org/D122738#inline-1180541
For info I tested with this value set and an assert(false); in the tests to verify all platforms support Japanese. Only on AIX it's unsupported. However this platform has a lot (all?) locale tests disabled.
The build can be found here
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits