[libcxx-commits] [PATCH] D122738: [libc++][test] Use the Japanese locale.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 8 10:53:51 PDT 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but have you verified that we were running that test in the CI? Since it `REQUIRES: locale.ja_JP.UTF-8`, we would simply skip it if the CI node didn't support that locale. Please make sure that's not what's happening, as we would simply lose coverage of that test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122738/new/

https://reviews.llvm.org/D122738



More information about the libcxx-commits mailing list