[libcxx-commits] [PATCH] D123129: [libc++] Add tests for std::string default constructor and destructor

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik marked 2 inline comments as done.
philnik added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/default.pass.cpp:40
+#if TEST_STD_VER > 17
+  // static_assert(test());
+#endif
----------------
nilayvaish wrote:
> Why is this commented out? Same question for the other file as well.
`std::string` isn't constexpr yet. This will be uncommented when `std::string` is made constexpr (D110598 if you want to review it :P).


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/dtor.pass.cpp:33-35
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
 std::wstring ws;
 #endif
----------------
nilayvaish wrote:
> Seems unused.
AFAICT this is supposed to be that way. The comment above says that it checks that the address of the destructors constructor can be taken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123129/new/

https://reviews.llvm.org/D123129