[libcxx-commits] [PATCH] D123129: [libc++] Add tests for std::string default constructor and destructor

[Nilay Vaish via Phabricator via libcxx-commits]

nilayvaish accepted this revision.
nilayvaish added a comment.

Minor comments, otherwise looks good to me.



================
Comment at: libcxx/test/std/strings/basic.string/string.cons/default.pass.cpp:40
+#if TEST_STD_VER > 17
+  // static_assert(test());
+#endif
----------------
Why is this commented out? Same question for the other file as well.


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/dtor.pass.cpp:33-35
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
 std::wstring ws;
 #endif
----------------
Seems unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123129/new/

https://reviews.llvm.org/D123129