[libcxx-commits] [PATCH] D123028: [libc++] Implement tests for private headers using the new generator

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added a comment.

In D123028#3426607 <https://reviews.llvm.org/D123028#3426607>, @Mordante wrote:

> Nice cleanup, thanks a lot!
>
> Just curious how did you remove the no longer needed files? I'm asking since I expect some new obsolete files might be added by reviews in progress.

I just did `rm -rf libcxx/test/libcxx/diagnostics/detail.headers`, since I think that's where all the old tests used to live. I'll do it again before landing, and folks should rebase their patches after I land this as well.



================
Comment at: libcxx/test/libcxx/private_headers.verify.cpp:26
+
+  print("{ifdef}#{indent}include <{header}> // expected-error@*:* {{{{use of private header from outside its module: '{header}'}}}}{endif}".format(
+    ifdef='#if ' + header_restrictions[header] + '\n' if header in header_restrictions else '',
----------------
Mordante wrote:
> guess we need to guard this `expected-error` from being processed in lit.
Indeed, thanks! This escaping is a little bit annoying, but I guess it's not the end of the world.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123028/new/

https://reviews.llvm.org/D123028