[libcxx-commits] [PATCH] D123028: [libc++] Implement tests for private headers using the new generator

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Nice cleanup, thanks a lot!

Just curious how did you remove the no longer needed files? I'm asking since I expect some new obsolete files might be added by reviews in progress.

LGTM once the CI is happy.



================
Comment at: libcxx/test/libcxx/private_headers.verify.cpp:26
+
+  print("{ifdef}#{indent}include <{header}> // expected-error@*:* {{{{use of private header from outside its module: '{header}'}}}}{endif}".format(
+    ifdef='#if ' + header_restrictions[header] + '\n' if header in header_restrictions else '',
----------------
guess we need to guard this `expected-error` from being processed in lit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123028/new/

https://reviews.llvm.org/D123028