[libcxx-commits] [PATCH] D121514: [libc++][format] Improve format-arg-store.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante planned changes to this revision.
Mordante added a comment.

In D121514#3422376 <https://reviews.llvm.org/D121514#3422376>, @vitaut wrote:

>> Can you explain why you dislike this approach?
>
> The codegen is strictly worse compared to {fmt}'s approach where the type alternatives are passed in a single register in a common case. See e.g. https://godbolt.org/z/sT54fcGET.

Thanks for the explanation. I'll look into it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121514/new/

https://reviews.llvm.org/D121514