[libcxx-commits] [PATCH] D121514: [libc++][format] Improve format-arg-store.

Victor Zverovich via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Apr 1 07:21:33 PDT 2022


vitaut added a comment.

> Can you explain why you dislike this approach?

The codegen is strictly worse compared to {fmt}'s approach where the type alternatives are passed in a single register in a common case. See e.g. https://godbolt.org/z/sT54fcGET.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121514/new/

https://reviews.llvm.org/D121514



More information about the libcxx-commits mailing list