[libcxx-commits] [PATCH] D110852: [libc++] Use addressof in assignment operator.

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter added inline comments.


================
Comment at: libcxx/test/support/deleted_operator_ampersand.h:18
+///
+/// The class has some additiona operations to be usable in all containers.
+struct deleted_operator_ampersand {
----------------
typo: "additional"


================
Comment at: libcxx/test/support/deleted_operator_ampersand.h:28
+template <>
+struct hash<deleted_operator_ampersand> {
+  std::size_t operator()(deleted_operator_ampersand const&) const noexcept { return 0; }
----------------
`#include<functional>`?


================
Comment at: libcxx/test/support/deleted_operator_ampersand.h:29
+struct hash<deleted_operator_ampersand> {
+  std::size_t operator()(deleted_operator_ampersand const&) const noexcept { return 0; }
+};
----------------
jloser wrote:
> Nit: west const in the function argument list to be consistent with use in the rest of the file.
`#include<cstddef>`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110852/new/

https://reviews.llvm.org/D110852