[libcxx-commits] [PATCH] D110852: [libc++] Use addressof in assignment operator.

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/assign_copy.compile.pass.cpp:23
+void test() {
+  std::priority_queue<deleted_operator_ampersand, std::vector<deleted_operator_ampersand> > pqo;
+  std::priority_queue<deleted_operator_ampersand, std::vector<deleted_operator_ampersand> > pq;
----------------
Should we explicitly `#include <vector>`? Do we even need to provide our own container template (I think using the default of `std::deque` is fine, right?)?


================
Comment at: libcxx/test/support/deleted_operator_ampersand.h:29
+struct hash<deleted_operator_ampersand> {
+  std::size_t operator()(deleted_operator_ampersand const&) const noexcept { return 0; }
+};
----------------
Nit: west const in the function argument list to be consistent with use in the rest of the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110852/new/

https://reviews.llvm.org/D110852