[libcxx-commits] [PATCH] D110794: [libc++][test] NFC: Don't include name in banner comment

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/support/constexpr_char_traits.h:1
-// -*- C++ -*-
-//===-------------------- constexpr_char_traits ---------------------------===//
----------------
Quuxplusone wrote:
> Mordante wrote:
> > I prefer to keep these in the header files .h can be a c or c++ file.
> > IMO removing them has little benefit and might break somebodies setup.
> FWIW, I //do// prefer to remove them from .h files to reduce cruft. I don't think anyone will work on libc++ very long in an editor that (1) cares what language the code is written in, and yet (2) can't be configured to open .h files as C++ by default.
> However, I don't care to submit such a PR myself, and don't care enough to complain if someone else (e.g. you :)) blocks it.  And I agree that it should be done in a separate (completely mechanical) commit. If other people want to go have the political discussion, and decide, and come back and tell me "OK, go remove all the editor comments from `find libcxx/ -name *.h`," I //do// volunteer to make that mechanical commit myself. :)
I'm not per se against removing it from the `.h` files, I only don't think it has a real benefit. Maybe we can discuss it on Discord and see whether it breaks the setup of our regular contributors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110794/new/

https://reviews.llvm.org/D110794