[libcxx-commits] [PATCH] D110794: [libc++][test] NFC: Don't include name in banner comment

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 30 09:40:42 PDT 2021


jloser added a comment.

In D110794#3033851 <https://reviews.llvm.org/D110794#3033851>, @Quuxplusone wrote:

> @jloser, I propose that I commandeer this PR to make the following completely mechanical changes in two separate and unreviewed commits:
>
> - Normalize the copyright notice (by cutting and pasting from a good file), for all files in `git grep '//===-----' libcxx/test/ | grep -v '//===----------------------------------------------------------------------===//'`
> - Remove `// -*- C++ -*-` from the first line of `find libcxx/test/ -name *.cpp` (but //not// from any other files)

Works for me Arthur. Feel free to do exactly that. I shouldn't have removed the `// -*- C++ -*-` comment when fixing the banner; should have let that be its own commit as you proposed.

FWIW, I'm OK removing the C++ editor comment in the `.h` files, but make sure @Mordante is on board.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110794/new/

https://reviews.llvm.org/D110794



More information about the libcxx-commits mailing list