[libcxx-commits] [PATCH] D110722: [libc++][Docs] Update benchmark doc wrt monorepo

[Shivam Gupta via Phabricator via libcxx-commits]

xgupta added inline comments.


================
Comment at: libcxx/docs/TestingLibcxx.rst:230
   $ cd build
-  $ cmake [options] <path to libcxx sources>
   $ make cxx-benchmarks
----------------
Mordante wrote:
> Mordante wrote:
> > Since our build documentation now uses ninja (https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build) I think it would be nice to change these instructions to ninja. 
> I don't mind removing this line, but I think the documentation should make it clear build directory already contains a generated CMake project.
But if the person wants to do testing or running the benchmark, it is certain that they have already built the libcxx and that build directory contains a generated CMake project. Sorry if I misunderstood your comment.


================
Comment at: libcxx/docs/TestingLibcxx.rst:231
   $ make cxx-benchmarks
 
 This will build all of the benchmarks under ``<libcxx-src>/benchmarks`` to be
----------------
fine


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110722/new/

https://reviews.llvm.org/D110722