[libcxx-commits] [PATCH] D110722: [libc++][Docs] Update benchmark doc wrt monorepo

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this!



================
Comment at: libcxx/docs/TestingLibcxx.rst:230
   $ cd build
-  $ cmake [options] <path to libcxx sources>
   $ make cxx-benchmarks
 
----------------
Since our build documentation now uses ninja (https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build) I think it would be nice to change these instructions to ninja. 


================
Comment at: libcxx/docs/TestingLibcxx.rst:230
   $ cd build
-  $ cmake [options] <path to libcxx sources>
   $ make cxx-benchmarks
----------------
Mordante wrote:
> Since our build documentation now uses ninja (https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build) I think it would be nice to change these instructions to ninja. 
I don't mind removing this line, but I think the documentation should make it clear build directory already contains a generated CMake project.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110722/new/

https://reviews.llvm.org/D110722