[libcxx-commits] [PATCH] D110515: [libc++] [compare] Named comparison functions, is_eq etc.

[Ruslan Arutyunyan via Phabricator via libcxx-commits]

rarutyun added a comment.

Overall, LGTM except the question with HIDE_FROM_ABI that is already raised and the small comment that I've left.



================
Comment at: libcxx/include/__compare/is_eq.h:1
+//===----------------------------------------------------------------------===//
+//
----------------
I would prefer to change this file to `named_comparison_functions.h` with the corresponding changes in guards and module.modulemap. From my perspective it gives better match to what section of the standard this private module implements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110515/new/

https://reviews.llvm.org/D110515