[libcxx-commits] [PATCH] D110515: [libc++] [compare] Named comparison functions, is_eq etc.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Would it be possible to handle the comment in `test/std/ranges/range.adaptors/range.transform/iterator/compare.pass.cpp:39` in this commit/in a separate commit?

  // TODO: when three_way_comparable is implemented and std::is_eq is implemented,

LGTM, but would like to see @ldionne's answer to `_LIBCPP_HIDE_FROM_ABI` since I think it should be added.



================
Comment at: libcxx/include/__compare/ordering.h:341
-_LIBCPP_HIDE_FROM_ABI
-constexpr bool is_gteq(partial_ordering __cmp) noexcept { return __cmp >= 0; }
-
----------------
Interesting only these 4 were implemented instead of all 6.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110515/new/

https://reviews.llvm.org/D110515