[libcxx-commits] [PATCH] D107721: [libc++][spaceship] Implement std::pair::operator<=>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.spec/three_way_comparison.pass.cpp:15
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17, libcpp-no-concepts
+
----------------
ldionne wrote:
> Mordante wrote:
> > mumbleskates wrote:
> > > Mordante wrote:
> > > > We normally start with this line, can you move it above `// <utility>`?
> > > That hasn't been my observation, all the adjacent tests (for tuple, for example) already have this line at the end where it is here. I put it where it is to match surrounding code. Grepping around the rest of the project shows no consistency at all in its placement so I'd like to prefer just matching the adjacent files.
> > Guess I've been looking at other files, but if this matches the local style it's fine by me.
> We are (unfortunately) pretty inconsistent about how we do this in the library right now -- that's been my observation since I started working on it.
IMO unless we have tooling to aid us it's very hard to get consistency. (Not that should stop us from trying to be consistent.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107721/new/

https://reviews.llvm.org/D107721