[libcxx-commits] [PATCH] D107721: [libc++][spaceship] Implement std::pair::operator<=>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/utilities/utility/pairs/pairs.spec/three_way_comparison.pass.cpp:15
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17, libcpp-no-concepts
+
----------------
Mordante wrote:
> mumbleskates wrote:
> > Mordante wrote:
> > > We normally start with this line, can you move it above `// <utility>`?
> > That hasn't been my observation, all the adjacent tests (for tuple, for example) already have this line at the end where it is here. I put it where it is to match surrounding code. Grepping around the rest of the project shows no consistency at all in its placement so I'd like to prefer just matching the adjacent files.
> Guess I've been looking at other files, but if this matches the local style it's fine by me.
We are (unfortunately) pretty inconsistent about how we do this in the library right now -- that's been my observation since I started working on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107721/new/

https://reviews.llvm.org/D107721