[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D88458#3010547 <https://reviews.llvm.org/D88458#3010547>, @ldionne wrote:

> This LGTM, but it's going to break some people who copy only some subdirectories of llvm. I think it's unavoidable, but we'll want to let them know. I think it might apply to e.g. @thakis.

Chromium is building libc++, libc++abi and libunwind outside of the monorepo, but they use their own GN build so this shouldn't affect them.

> I assume we'll also want to move more common stuff to `<root>/cmake` in the future? A common place for CMake modules has been sorely needed for a while, thanks for getting the ball rolling!

Yes, that's the plan. In particular, after D110005 <https://reviews.llvm.org/D110005> lands, I'd like to move most of the helper macros and functions from `libcxx/cmake/Modules/HandleLibcxxFlags.cmake` that are shared across runtimes to `<root>/cmake` so we don't need to keep them in sync manually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458