[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a subscriber: thakis.
ldionne added a comment.

This LGTM, but it's going to break some people who copy only some subdirectories of llvm. I think it's unavoidable, but we'll want to let them know. I think it might apply to e.g. @thakis.

I assume we'll also want to move more common stuff to `<root>/cmake` in the future? A common place for CMake modules has been sorely needed for a while, thanks for getting the ball rolling!



================
Comment at: compiler-rt/cmake/config-ix.cmake:19
   include(HandleCompilerRT)
-  find_compiler_rt_library(builtins "" COMPILER_RT_BUILTINS_LIBRARY)
+  cmake_push_check_state()
+  set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${SANITIZER_COMMON_FLAGS}")
----------------
Wasn't aware of this, it's pretty awesome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458