[libcxx-commits] [PATCH] D109435: [libc++][NFC] Rename _EnableIf to __enable_if_t for consistency

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Per my latest comment/update on D109411 <https://reviews.llvm.org/D109411>: I buy this now. We're switching away from the SCARY metabase technique (which irreparably interferes with the good diagnostics) at the same time that we're switching away from the `_EnableIf` name. Simultaneously, on the Clang side, we're special-casing the //new// name, `__enable_if_t`, so that it will start giving the good diagnostics.

(I think it would still be nice to decide whether we are going to use `__enable_if_t` throughout for consistency, or permit `_LIBCPP_STD_VER > 11` codepaths to use `enable_if_t` if they want. I predict the latter will win out anyway, though.)

LGTM, ship it! Assuming you agree with D109411 <https://reviews.llvm.org/D109411> at this point too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109435/new/

https://reviews.llvm.org/D109435