[libcxx-commits] [PATCH] D112211: [libcxx] [test] Change LIBCXX-WINDOWS-FIXME into XFAIL: msvc for cases that succeed in mingw configurations

Thu Oct 21 07:15:03 PDT 2021

mstorsjo requested review of this revision.
mstorsjo added inline comments.

================
Comment at: libcxx/test/std/language.support/support.dynamic/alloc.errors/set.new.handler/get_new_handler.pass.cpp:11-12

-// XFAIL: LIBCXX-WINDOWS-FIXME
+// FIXME: This XFAIL has no explanation yet.
+// XFAIL: msvc

----------------
ldionne wrote:
> I don't understand why we're not keeping `LIBCXX-WINDOWS-FIXME` in those cases.
Because `LIBCXX-WINDOWS-FIXME` is set in both msvc and mingw configurations, but the test succeeds in mingw configs, so the bug, whatever it is, is specific to msvc. When adding mingw CI, these tests give “unexpectedly passed” errors.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112211/new/

https://reviews.llvm.org/D112211