[libcxx-commits] [PATCH] D112211: [libcxx] [test] Change LIBCXX-WINDOWS-FIXME into XFAIL: msvc for cases that succeed in mingw configurations

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 21 06:56:04 PDT 2021


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/std/language.support/support.dynamic/alloc.errors/set.new.handler/get_new_handler.pass.cpp:11-12
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// FIXME: This XFAIL has no explanation yet.
+// XFAIL: msvc
 
----------------
I don't understand why we're not keeping `LIBCXX-WINDOWS-FIXME` in those cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112211/new/

https://reviews.llvm.org/D112211



More information about the libcxx-commits mailing list