[libcxx-commits] [PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

[Steven Wu via Phabricator via libcxx-commits]

steven_wu added a comment.

I don't know enough about Dwarf unwinding but the implementation looks generally good. Can you please add a testcase indicating how ORCJIT is planning to use it?



================
Comment at: libunwind/src/DwarfParser.hpp:158
+                               FDE_Info *fdeInfo, CIE_Info *cieInfo,
+                               bool useCIEInfo = false);
   static bool parseFDEInstructions(A &addressSpace, const FDE_Info &fdeInfo,
----------------
Can you document how and when this parameter should be used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111863/new/

https://reviews.llvm.org/D111863