[libcxx-commits] [PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

[Lang Hames via Phabricator via libcxx-commits]

lhames accepted this revision.
lhames added a comment.

This looks good to me, but we should get a libunwind contributor to weigh in too.

I've been trying to think of a good way to test this, but it's awkward. The best strategy that I've come up with, at least for testing within libunwind itself, would be to compile a test case with eh-frame tables written in by hand (as C arrays, compile it with `-fno-asynchronous-unwind-tables`, patch up the tables manually with C code at runtime, and then register/use/deregister them. That's all pretty awkward, which is probably why there are no existing tests for the dynamic registration APIs.

I think the ORC runtime provides a much more natural way to test this. Did you manage to come up with some ORC-runtime based tests in the end?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111863/new/

https://reviews.llvm.org/D111863