[libcxx-commits] [PATCH] D111244: [libc++][AIX] Add scripts and config for building with the libcxx CI infrastructure

David Tenty via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 13 07:36:28 PDT 2021


daltenty marked an inline comment as done.
daltenty added inline comments.


================
Comment at: libcxxabi/test/configs/cmake-bridge.cfg.in:1
+ at AUTO_GEN_COMMENT@
+
----------------
ldionne wrote:
> I'm trying to tackle this in D111279, actually. To make progress on this patch, would you be OK with re-applying your changes to the legacy `config.py` so that you run the libc++ tests on top of the new config, but the libc++abi tests on top of the old config? Then, once I manage to land D111279, we'll eventually remove the legacy config and you'll switch to running the libc++abi tests on the new config.
> 
> Does that make sense? Trying to find a pragmatic approach here.
I'm ok with pragmatically reverting the c++abi piece to the old config if necessary, but it looks like you've just landed D111279 as of this writing 🙂. So I'm going to rebase this to follow that precedent and let's see if we can keep everything to the new config.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111244/new/

https://reviews.llvm.org/D111244



More information about the libcxx-commits mailing list