[libcxx-commits] [PATCH] D111244: [libc++][AIX] Add scripts and config for building with the libcxx CI infrastructure

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/ci/run-buildbot:123-146
+function check-cxx-cxxabi-base() {
     echo "+++ Running the libc++ tests"
     ${NINJA} -vC "${BUILD_DIR}" check-cxx
 
     echo "+++ Running the libc++abi tests"
     ${NINJA} -vC "${BUILD_DIR}" check-cxxabi
 
----------------
Suggestion: Instead, don't touch `check-runtimes` and just do this below under `aix)`:

```
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi
${NINJA} -vC "${BUILD_DIR}" check-cxx check-cxxabi
```

You can add a TODO comment to use `check-runtimes` instead when `libunwind` works cleanly on the platform. That localizes the workaround more IMO.


================
Comment at: libcxxabi/test/configs/cmake-bridge.cfg.in:1
+ at AUTO_GEN_COMMENT@
+
----------------
I'm trying to tackle this in D111279, actually. To make progress on this patch, would you be OK with re-applying your changes to the legacy `config.py` so that you run the libc++ tests on top of the new config, but the libc++abi tests on top of the old config? Then, once I manage to land D111279, we'll eventually remove the legacy config and you'll switch to running the libc++abi tests on the new config.

Does that make sense? Trying to find a pragmatic approach here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111244/new/

https://reviews.llvm.org/D111244