[libcxx-commits] [PATCH] D103466: [libc++][format] Adds char formatter.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 7 08:15:31 PDT 2021


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_char.pass.cpp:437
+int main(int, char**) {
+#ifndef _WIN32
+  // Make sure the parsers match the expectations. The layout of the
----------------
ldionne wrote:
> Can you add a comment explaining why that's not satisfied on Windows?
I added a TODO FMT. LWG 3576 will probably change the size of the `Parser`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103466/new/

https://reviews.llvm.org/D103466



More information about the libcxx-commits mailing list