[libcxx-commits] [PATCH] D103466: [libc++][format] Adds char formatter.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

For lurkers -- I'm going through these patches and looking out for libc++ specific things. We agreed with @Mordante to rely on @vitaut 's review and the test coverage here for the correctness of the actual code, which is why I have so few comments.



================
Comment at: libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_char.pass.cpp:437
+int main(int, char**) {
+#ifndef _WIN32
+  // Make sure the parsers match the expectations. The layout of the
----------------
Can you add a comment explaining why that's not satisfied on Windows?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103466/new/

https://reviews.llvm.org/D103466