[libcxx-commits] [PATCH] D110852: [libc++] Use addressof in assignment operator.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 5 12:09:10 PDT 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/containers/sequences/list/list.cons/assign_copy.compile.pass.cpp:9
+
+// XFAIL: LIBCXX-DEBUG-FIXME
+
----------------
ldionne wrote:
> Can you add a comment explaining why that fails? Applies elsewhere too.
Good catches! I didn't notice these new XFAILs; I also don't see any reason they should be needed. I assume the problem has to do with `__wrap_iter` not being sufficiently ADL-proof? But then we should fix that too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110852/new/

https://reviews.llvm.org/D110852



More information about the libcxx-commits mailing list