[libcxx-commits] [PATCH] D110852: [libc++] Use addressof in assignment operator.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for tackling this! LGTM but I do have a few questions.



================
Comment at: libcxx/test/std/containers/sequences/forwardlist/forwardlist.cons/assign_copy.compile.pass.cpp:9
+
+// UNSUPPORTED: libcxx-no-debug-mode
+
----------------
Why does this test require the debug mode?


================
Comment at: libcxx/test/std/containers/sequences/list/list.cons/assign_copy.compile.pass.cpp:9
+
+// XFAIL: LIBCXX-DEBUG-FIXME
+
----------------
Can you add a comment explaining why that fails? Applies elsewhere too.


================
Comment at: libcxx/test/support/operator_hijacker.h:12
+
+#include "test_macros.h"
+
----------------
Generally this goes after including the libc++ headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110852/new/

https://reviews.llvm.org/D110852