[libcxx-commits] [PATCH] D110503: [libc++] Implement P1394r4 for span: range constructor

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/containers/views/span.cons/iterator_len.pass.cpp:21
+#include <cassert>
+#include <type_traits>
+
----------------
`#include <iterator>` for `std::data` and `std::size`.
Generally, check the output of
```
./bin/llvm-lit -sv --param std=c++2b --param cxx_under_test=`pwd`/bin/clang++ --param enable_modules=True ../libcxx/test/std/containers/views/
```
(notice `--param enable_modules=True`) and fix the things it complains about, both in <span> and in the tests. buildkite will also test this, in the "Modules" build step; but the above magic incantation will let you do it locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110503/new/

https://reviews.llvm.org/D110503