[libcxx-commits] [PATCH] D110503: [libc++] Implement P1394r4 for span: range constructor

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/containers/views/span.cons/iterator_len.verify.cpp:28
+  int arr[] = {1, 2, 3};
+  createImplicitSpan<int, 1>(arr, 1);
+
----------------
If you decide to keep a `.verify.cpp` test for `span`, then please add a test for
```
std::span<const int> sp = {0, 0};
```
Today we accept that (interpreting `0` as a null pointer constant); after this PR we should correctly reject it (as libstdc++ and MSVC already do).



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110503/new/

https://reviews.llvm.org/D110503