[libcxx-commits] [PATCH] D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: libc++, ldionne, Mordante, fwolff, var-const, jloser, philnik.
Quuxplusone added a project: libc++.
Herald added a subscriber: mgrang.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

This is my suggested regression test for D113868 <https://reviews.llvm.org/D113868>, plus some matching improvements to my existing "robust_against_adl" test.

Also, mark these tests as compile-only. They actually //are// safe to run — notice that the code "runs" at constexpr-time in C++20, without error — because both of the input ranges are entirely filled with nullptr, so no matter how you shuffle the elements, they remain sorted and partitioned and heapified and everything. But there's no real //reason// to run them at runtime, so let's just avoid the distraction.

Test cases that fail in trunk right now are commented out with `TODO FIXME`. D113868 <https://reviews.llvm.org/D113868> currently fixes some-but-not-all of them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113906

Files:
  libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp
  libcxx/test/std/algorithms/robust_against_adl.pass.cpp
  libcxx/test/std/algorithms/robust_re_difference_type.compile.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113906.387285.patch
Type: text/x-patch
Size: 32974 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211115/2b8a4ccf/attachment-0001.bin>