[libcxx-commits] [PATCH] D113906: [libc++] [test] Add "robust_re_difference_type.compile.pass.cpp" for all the algorithms.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general looks good, but some questions.



================
Comment at: libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp:7
+//
+//===----------------------------------------------------------------------===//
+
----------------
My concern with this test is a bit, how can we keep it up-to-date when newer versions of the Standard add new algorithms.
I don't see this as a blocker, but if you have any suggestions I'd like to hear them.


================
Comment at: libcxx/test/std/algorithms/robust_against_adl.compile.pass.cpp:57
+    (void)std::for_each(first, last, [](void*){});
+#if TEST_STD_VER >= 17
+    (void)std::for_each_n(first, count, [](void*){});
----------------
Is there a reason to change from our usual pattern of `#if TEST_STD_VER > 14`?
IIRC this question was raised in a review not that long ago, but I don't recall that we wanted to move to this style.


================
Comment at: libcxx/test/std/algorithms/robust_re_difference_type.compile.pass.cpp:87
+    (void)std::copy(first, last, first2);
+    // TODO FIXME (void)std::copy_n(first, count, first2);
+    (void)std::copy_backward(first, last, last2);
----------------
Any idea why this one fails?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113906/new/

https://reviews.llvm.org/D113906