[libcxx-commits] [PATCH] D114456: [libc++] Fix backdeployment annotations for std::filesystem

Wed Nov 24 13:57:56 PST 2021

ldionne accepted this revision as: libc++.
ldionne added a comment.
This revision is now accepted and ready to land.

In D114456#3149368 <https://reviews.llvm.org/D114456#3149368>, @jloser wrote:

> LGTM. Thanks for fixing this! I wish it could have been caught by CI when it was introduced, so that's room for future improvement.
>
> Do we need to do `_LIBCPP_AVAILABILITY_FILESYSTEM_PUSH` and corresponding `_LIBCPP_AVAILABILITY_FILESYSTEM_POP` around these template specializations to workaround https://bugs.llvm.org/show_bug.cgi?id=41078? I think the answer is "No", but wanted to confirm. :)

Nope, it doesn't seem necessary, perhaps because `directory_iterator` isn't a template. I'm not too sure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114456/new/

https://reviews.llvm.org/D114456