[libcxx-commits] [PATCH] D114456: [libc++] Fix backdeployment annotations for std::filesystem

Tue Nov 23 10:52:40 PST 2021

jloser accepted this revision.
jloser added a comment.

LGTM. Thanks for fixing this! I wish it could have been caught by CI when it was introduced, so that's room for future improvement.

Do we need to do `_LIBCPP_AVAILABILITY_FILESYSTEM_PUSH` and corresponding `_LIBCPP_AVAILABILITY_FILESYSTEM_POP` around these template specializations to workaround https://bugs.llvm.org/show_bug.cgi?id=41078? I think the answer is "No", but wanted to confirm. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114456/new/

https://reviews.llvm.org/D114456